Skip to content

porchctl improvements#554

Open
mozesl-nokia wants to merge 8 commits into
kptdev:mainfrom
nokia:porchctl-improvements
Open

porchctl improvements#554
mozesl-nokia wants to merge 8 commits into
kptdev:mainfrom
nokia:porchctl-improvements

Conversation

@mozesl-nokia
Copy link
Copy Markdown
Collaborator

@mozesl-nokia mozesl-nokia commented Apr 22, 2026

Title

porchctl improvements


Description

  • What changed:
    • Cleaned up porchctl rpkg get field selectors, made the selectors additive
    • Explicit --namespace is no longer necessary for most commands, will try to default to kubeconfig context, env var, or "default"
    • Added a bunch of aliases and shorthands for command flags
    • porchctl rpkg pull can now overwrite a folder's contents if it is the same package or --force is passed to it
  • Why it’s needed: To make porchctl more user friendly
  • How it works: See "What changed"

Related Issue(s)

None


Type of Change

  • Enhancement
  • Refactor
  • Documentation
  • Tests

Checklist

  • Code follows project style guidelines
  • Self-reviewed changes
  • Tests added/updated
  • Documentation added/updated
  • All tests and gating checks pass

Additional Notes (Optional)

  • Known issues:
  • Further improvements:
  • Review notes: ~800 lines are just tests and test code, so the "production" part is only ~350

AI Disclosure

  • I have used AI in the creation of this PR.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 22, 2026

Deploy Preview for porch ready!

Name Link
🔨 Latest commit 540d169
🔍 Latest deploy log https://app.netlify.com/projects/porch/deploys/69ef584b9a301e0008519029
😎 Deploy Preview https://deploy-preview-554--porch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mozesl-nokia mozesl-nokia force-pushed the porchctl-improvements branch 2 times, most recently from eebc406 to 8b9b220 Compare April 23, 2026 15:08
@mozesl-nokia mozesl-nokia marked this pull request as ready for review April 23, 2026 15:08
@mozesl-nokia mozesl-nokia added enhancement New feature or request go Pull requests that update go code cleanup labels Apr 23, 2026
@mozesl-nokia mozesl-nokia mentioned this pull request Apr 24, 2026
12 tasks
@mozesl-nokia
Copy link
Copy Markdown
Collaborator Author

I don't think getting the coverage much higher can be done meaningfully...

@mozesl-nokia mozesl-nokia added the size:L This PR changes 100-499 lines, ignoring generated files. label Apr 24, 2026
@mozesl-nokia mozesl-nokia force-pushed the porchctl-improvements branch from 8b9b220 to 540d169 Compare April 27, 2026 12:36
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
50.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@Catalin-Stratulat-Ericsson
Copy link
Copy Markdown
Contributor

Catalin-Stratulat-Ericsson commented May 6, 2026

seems mostly fine but i haven't had a proper deep dive review but just a few questions.

  1. firstly why in the description do we mark documentation as included in this PR if there is none?
  2. secondly if were making cli changes to arguments should these not also be represented in our docs here? https://docs.porch.nephio.org/docs/7_cli_api/porchctl/
  3. were not including any major or incompatible changes to our CLI with this are we? e.g. https://github.com/nephio-project/porch/actions/runs/25310073067 * please ignore the clone and init failure messages they are just due to text changes on the CLI output.

ill do more of a deep dive review a little later but looks good so far. thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup do-not-merge/hold #ededed enhancement New feature or request go Pull requests that update go code size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants