porchctl improvements#554
Open
mozesl-nokia wants to merge 8 commits into
Open
Conversation
✅ Deploy Preview for porch ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
eebc406 to
8b9b220
Compare
Collaborator
Author
|
I don't think getting the coverage much higher can be done meaningfully... |
8b9b220 to
540d169
Compare
|
12 tasks
Contributor
|
seems mostly fine but i haven't had a proper deep dive review but just a few questions.
ill do more of a deep dive review a little later but looks good so far. thank you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Title
porchctlimprovementsDescription
porchctl rpkg getfield selectors, made the selectors additive--namespaceis no longer necessary for most commands, will try to default to kubeconfig context, env var, or "default"porchctl rpkg pullcan now overwrite a folder's contents if it is the same package or--forceis passed to itRelated Issue(s)
None
Type of Change
Checklist
Additional Notes (Optional)
AI Disclosure