Skip to content

Move docker builds to ghcr#982

Merged
liamfallon merged 3 commits into
kptdev:mainfrom
Nordix:move_builds_to_ghcr
May 15, 2026
Merged

Move docker builds to ghcr#982
liamfallon merged 3 commits into
kptdev:mainfrom
Nordix:move_builds_to_ghcr

Conversation

@efiacor
Copy link
Copy Markdown
Collaborator

@efiacor efiacor commented May 15, 2026

Title

Move porch image builds to ghcr.


Description

  • What changed: Build and push to ghcr. Update relevant yaml and docs
  • Why it’s needed: Move to kptdev
  • How it works: See changes

Related Issue(s)

  • Closes/Fixes #

Type of Change

  • Bug fix
  • New feature
  • Enhancement
  • Refactor
  • Documentation
  • Tests
  • Other: ________

Checklist

  • Code follows project style guidelines
  • Self-reviewed changes
  • Tests added/updated
  • Documentation added/updated
  • All tests and gating checks pass

Testing Instructions (Optional)


Additional Notes (Optional)

  • Known issues:
  • Further improvements:
  • Review notes:

AI Disclosure

[X] I have used AI in the creation of this PR.

Kiro

Signed-off-by: Fiachra Corcoran <fiachra.corcoran@est.tech>
Copilot AI review requested due to automatic review settings May 15, 2026 00:03
@efiacor efiacor self-assigned this May 15, 2026
@efiacor efiacor added the refactoring #b33d8f label May 15, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@Catalin-Stratulat-Ericsson
Copy link
Copy Markdown
Contributor

just a quick comment. could be silly so please let me know but im wondering if this would affect the github runners and just in general? weve been noticing github slowing down here and there especially as we have been increasing the runners #. im a little concerned with moving the builds to the ghcr we might start encountering more issues on that end like we saw with the runners? just a thought

Comment thread Makefile Outdated
@Catalin-Stratulat-Ericsson
Copy link
Copy Markdown
Contributor

curious about the catalog repo also would that not need changes also now when this comes in?

liamfallon
liamfallon previously approved these changes May 15, 2026
@liamfallon
Copy link
Copy Markdown
Collaborator

curious about the catalog repo also would that not need changes also now when this comes in?

I think we need to do something about our default Porch "canned" download being in the Nephio catalog repo but I don't think it should be on this PR. I have added a new issue for this, see: kptdev/kpt#4495

Comment thread Makefile Outdated
Copilot AI review requested due to automatic review settings May 15, 2026 20:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.

Comment thread Makefile
Comment thread .github/workflows/image-build-push-dev.yaml
Comment thread .github/workflows/image-build-push-release.yaml
@liamfallon liamfallon merged commit 2015e37 into kptdev:main May 15, 2026
25 of 27 checks passed
@efiacor efiacor deleted the move_builds_to_ghcr branch May 16, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants