Allow the usage of mirror registries/repositories in all/most places#984
Open
mozesl-nokia wants to merge 4 commits into
Open
Allow the usage of mirror registries/repositories in all/most places#984mozesl-nokia wants to merge 4 commits into
mozesl-nokia wants to merge 4 commits into
Conversation
Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds environment-variable-driven registry/mirror overrides for development builds, deployment scripts, kpt functions, and DB tests so contributors can work behind registry/proxy restrictions.
Changes:
- Adds
.env/environment support for GHCR, Docker Hub, and Maven mirror configuration. - Replaces hardcoded kpt function and Docker base image registries with configurable prefixes.
- Extends DB tests and dev setup scripts to consume mirror-related environment variables.
Reviewed changes
Copilot reviewed 24 out of 25 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
.env.template |
Documents mirror-related environment variables. |
Makefile |
Exports registry mirror defaults and adds dump-env. |
build/Dockerfile |
Makes Docker Hub base images configurable. |
build/Dockerfile.apiserver |
Adds usage TODO comment. |
build/Dockerfile.etcd |
Adds usage TODO comment. |
build/Makefile |
Passes Docker Hub mirror build args. |
controllers/Dockerfile |
Makes builder base image configurable. |
controllers/Makefile |
Passes Docker Hub mirror build args. |
func/Dockerfile |
Makes kpt function and base image registries configurable. |
func/Dockerfile-wrapperserver |
Makes base images configurable. |
func/Makefile |
Passes mirror-related build args. |
go.mod |
Adds godotenv dependency. |
go.sum |
Adds checksums for godotenv. |
make/deploy.mk |
Adjusts setup-dev-env help placement. |
pkg/cache/dbcache/dbcache_test.go |
Loads .env and applies Maven mirror to embedded Postgres. |
scripts/common.sh |
Loads .env and centralizes mirror defaults. |
scripts/create-deployment-blueprint.sh |
Uses configurable kpt function images and env-based Docker Hub mirror. |
scripts/create-deployment-config.sh |
Passes GHCR prefix to deployment blueprint generation. |
scripts/create-deployment-kpt.sh |
Uses configurable kpt function images. |
scripts/install-dev-gitea-setup.sh |
Sources common config and applies mirrors to Gitea setup. |
scripts/remove-controller-from-deployment-config.sh |
Uses configurable kpt function image prefix. |
scripts/remove-porch-server-from-deployment-config.sh |
Uses configurable kpt function image prefix. |
scripts/run-load-test.sh |
Uses configurable kpt function image prefix. |
test/Dockerfile |
Adds usage TODO comment. |
test/Makefile |
Adds usage TODO comment. |
Comments suppressed due to low confidence (1)
scripts/create-deployment-kpt.sh:136
- This is another
PORCH_GHCR_PREFIX_URLuse in aset -uscript that never initializes the variable. A direct run without the env var fails here before deployment customization can proceed.
--image "${PORCH_GHCR_PREFIX_URL}/starlark:v0.5.5" \
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| # TODO: do we still use this? |
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| # TODO: do we still use this? |
Comment on lines
+15
to
+16
| # TODO: do we still use this? | ||
|
|
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| # TODO: do we still use this? |
Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Allow the usage of mirror registries/repositories in all/most places
Description
Related Issue(s)
(I thought we opened (and fixed) an issue for this, but I cannot find it.)
Type of Change
Checklist
Testing Instructions (Optional)
make setup-dev-envmake run-in-kind-db-cachereload-serverandreload-function-runner, but please try your favourite make targets and scripts too to make sure they all work.Additional Notes (Optional)
AI Disclosure
I have not used AI in the creation of this PR.