Open
Conversation
Collaborator
Author
|
I think these fixes work but looks like there's also some docs building issue and also one test is failing not sure why. |
Collaborator
Author
|
@krischer what's the reasoning behind this one? a58e8052d110ca4ae0284e2767bfb55f060ea6ae It's failing a test that is explicitly using an empty network string (the test data also has an empty network. |
Collaborator
Author
|
If there's no objections I'm gonna merge this one. Pretty sure that test fails are unrelated and master branch is failing CI anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
..and also update install docs.