Reduce lag when panning zoomed-out galactic map#1
Open
ritikmishra wants to merge 2 commits intokronosaur:masterfrom
Open
Reduce lag when panning zoomed-out galactic map#1ritikmishra wants to merge 2 commits intokronosaur:masterfrom
ritikmishra wants to merge 2 commits intokronosaur:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cause of the lag
To draw empire names under capital worlds when the map is zoomed out,
$GalacticMap.onDrawiterates through a list through all sovereigns playing the game. However, despite only having ~250 non-null elements, the list is ~3.9 million items long because the array is indexed by the sovereign ID.The solution
By using an object instead of an array, the time spent drawing sovereign names is reduced.