Closed
Conversation
Contributor
Author
|
Implementing |
Contributor
Author
|
TODO: Remove |
…DevicePrep to check slot IDs
Contributor
Author
|
TODO: Fix exception when accessing device at slot for ships with devices assigned to specific slot IDs. |
exinfinitum
commented
Nov 12, 2021
exinfinitum
commented
Nov 13, 2021
…bj 'deviceSlotIDs
Contributor
|
This PR can be safely closed since #246 will be able to act as an up-to-date reference until implementation of the desired features is completed |
Member
|
Closing this as we have an updated reference PR, and george decided not to take these changes as-is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ability to install devices to device slots by IDshpInstallDeviceobjCanInstallItemto check installation of items to device slots taking into account criteria, maxMass, maxPower, maxPowerPercentage fieldsand prevent installation if these conditions are not met (also allow installation into unoccupied device slots)Add similar checks toshpCanInstallDevicedescription,attributes,maxMass,maxPowerandmaxPowerPercentagefields to deviceSlotsobjGetPropertyto enable getting device slot info