Skip to content

Device slot improvements#75

Closed
exinfinitum wants to merge 26 commits intokronosaur:masterfrom
exinfinitum:deviceSlotImprovements
Closed

Device slot improvements#75
exinfinitum wants to merge 26 commits intokronosaur:masterfrom
exinfinitum:deviceSlotImprovements

Conversation

@exinfinitum
Copy link
Copy Markdown
Contributor

@exinfinitum exinfinitum commented Mar 27, 2021

  • Add ability to install devices to device slots by ID
  • Enable "force install to device slot" option in shpInstallDevice objCanInstallItem to check installation of items to device slots taking into account criteria, maxMass, maxPower, maxPowerPercentage fields and prevent installation if these conditions are not met (also allow installation into unoccupied device slots)
  • Add similar checks to shpCanInstallDevice
  • Add description, attributes, maxMass, maxPower and maxPowerPercentage fields to deviceSlots
  • Add new options to objGetProperty to enable getting device slot info

@exinfinitum
Copy link
Copy Markdown
Contributor Author

exinfinitum commented Apr 29, 2021

Implementing targetCriteria support will be quite a bit more complicated. We may want to leave that as well as the ability to specify targetCriteria in weapon xml definitions to another PR, and just merge the current feature set as is for this PR.

@exinfinitum exinfinitum marked this pull request as ready for review May 6, 2021 22:13
@exinfinitum exinfinitum marked this pull request as draft June 6, 2021 19:47
@exinfinitum
Copy link
Copy Markdown
Contributor Author

TODO: Remove force install to device slot for shpInstallDevice. Do not remove this argument from objCanInstallItem.

@exinfinitum exinfinitum changed the title [WIP] Device slot improvements Device slot improvements Jun 6, 2021
@exinfinitum exinfinitum marked this pull request as ready for review June 7, 2021 05:32
@exinfinitum
Copy link
Copy Markdown
Contributor Author

TODO: Fix exception when accessing device at slot for ships with devices assigned to specific slot IDs.

@exinfinitum exinfinitum marked this pull request as draft November 12, 2021 07:10
@exinfinitum exinfinitum marked this pull request as ready for review November 13, 2021 03:45
@FlufflesTheMicrosaur
Copy link
Copy Markdown
Contributor

This PR can be safely closed since #246 will be able to act as an up-to-date reference until implementation of the desired features is completed

@ArisayaDragon
Copy link
Copy Markdown
Member

Closing this as we have an updated reference PR, and george decided not to take these changes as-is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants