Changed Heronames, added missing or reworked Abilities and Cooldown Information to Abilities#106
Open
j1gs4w wants to merge 5 commits into
Open
Changed Heronames, added missing or reworked Abilities and Cooldown Information to Abilities#106j1gs4w wants to merge 5 commits into
j1gs4w wants to merge 5 commits into
Conversation
Changed Lycan, Wisp and Arc Warden
added missing Abilities (most of them were because of new aghs upgrades or reworked heroes) and added cooldown information to every ability
j1gs4w
changed the title
|
This is awesome. The only problem is I keep geting an erorr if the id doesnt have a cooldown, it should return 0 or something. Also, it would be super if the ability had a is_ultimate true or false for each ability if you can. Thanks a lot. |
…and isUltimate Fixed the check in getAbilityCooldown and renamed it to getCooldownById. Added getCooldownsById to get all Cooldowns of an Ability. Added the method isUltimate (hope it works for now until i can add an boolean in the abilities.json)
Author
|
Sorry i changed the order of checks in the method and messed it up by that.^^ |
Added Ability Information if it is an Ultimate and changed the method isUltimate($id)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed Lycan, Wisp and Arc Warden to match
official Dota 2 names and your name conventions
Added missing or reworked Abilities and Cooldown Information and the method getAbilityCooldown($id, $level) in Abilities.php
@Cst2989