Filter only relevant workloads that are supported by Kruize.#1922
Draft
kusumachalasani wants to merge 2 commits into
Draft
Filter only relevant workloads that are supported by Kruize.#1922kusumachalasani wants to merge 2 commits into
kusumachalasani wants to merge 2 commits into
Conversation
Signed-off-by: kusuma chalasani <kchalasa@redhat.com>
Signed-off-by: kusuma chalasani <kchalasa@redhat.com>
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRestricts imported workloads to native Kubernetes types supported by Kruize by tightening the Prometheus queries in the local monitoring metadata profile to only consider specific workload_type labels. Sequence diagram for filtered workload import using Prometheus queriessequenceDiagram
participant Kruize
participant Prometheus
Kruize->>Prometheus: query namespace_workload_pod:kube_pod_owner:relabel with workload_type filter
Prometheus-->>Kruize: metrics for deployment|statefulset|daemonset|barepod|pod
Kruize->>Kruize: import supported workloads only
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Filter only relevant workloads that are supported by Kruize.
Currently Kruize imports all the available workloads in the cluster irrespective of the type.
Here is the table of workloads that are considered / not considered.
Considered the workload types that are supported by native.
No third party workload type (like Argo, Knative etc) are considered.
ToDo:
Current code supports following workload types to createExperiment.
deployment, deploymentConfig, statefulset, replicaset, replicationcontroller, daemonset and job.
So, will be removing support for deploymentConfig, replicationcontroller, replicaset and job.
Type of change
How has this been tested?
After installing kruize and import datasource, only the supported workload types should show up.
Test Configuration
ITCP cluster
Checklist 🎯
Additional information
Include any additional information such as links, test results, screenshots here
Summary by Sourcery
Bug Fixes: