feature #369 add steps to Cleanup on bootstrap fail#705
Open
VishnuJin wants to merge 1 commit intokrustlet:mainfrom
Open
feature #369 add steps to Cleanup on bootstrap fail#705VishnuJin wants to merge 1 commit intokrustlet:mainfrom
VishnuJin wants to merge 1 commit intokrustlet:mainfrom
Conversation
VishnuJin
requested review from
bacongobbler,
kflansburg,
technosophos and
thomastaylor312
as code owners
VishnuJin
force-pushed
the
feature-369-cleanup-on-bootstrap-fail
branch
3 times, most recently
from
e49e9e9 to
95429a6
Compare
Contributor
Author
|
Im not sure why e2e fails, It passes on my local 😕 Edit: Just came across #687 |
Member
|
@VishnuJin you can download the logs from the actions pipeline. Don't worry about the windows-e2e as that has been having issues |
VishnuJin
force-pushed
the
feature-369-cleanup-on-bootstrap-fail
branch
from
95429a6 to
a303840
Compare
Signed-off-by: VishnuJin <vishnujin@outlook.com>
VishnuJin
force-pushed
the
feature-369-cleanup-on-bootstrap-fail
branch
from
caf39ea to
5bc5527
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #369
@thomastaylor312 is this the right approach ?