Skip to content

Add Firefox cross-browser validation (Phase 7 Batch B)#215

Merged
ktjn merged 2 commits into
mainfrom
claude/ci-failures-rb8zwi
Jul 23, 2026
Merged

Add Firefox cross-browser validation (Phase 7 Batch B)#215
ktjn merged 2 commits into
mainfrom
claude/ci-failures-rb8zwi

Conversation

@ktjn

@ktjn ktjn commented Jul 23, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add Firefox as a second Playwright project in web/playwright.config.ts so the full e2e suite runs against both Chromium and Firefox
  • Guard the EditContext assertion in playground.spec.ts behind a browserName === 'chromium' check since Firefox does not implement the EditContext API
  • Skip the textarea fallback test on Firefox where it is vacuously true (Firefox always uses the textarea path)
  • Update CI workflow to install both Chromium and Firefox browsers

Test plan

  • All 32 existing Chromium e2e tests pass unchanged
  • Firefox project runs all applicable tests (skipping EditContext-specific ones)
  • Conformance, AI actions, and service worker tests pass on both browsers
  • CI installs Firefox alongside Chromium and runs both projects

🤖 Generated with Claude Code

https://claude.ai/code/session_01PMWte55jcfTbjieG4nHD8C


Generated by Claude Code

claude added 2 commits July 23, 2026 07:58
Add Firefox as a second Playwright project so the full e2e suite runs
against both Chromium and Firefox. Guard the EditContext assertion
behind a chromium-only check since Firefox does not implement that API,
and skip the textarea fallback test on Firefox where it is vacuously
true. Update CI to install both Chromium and Firefox browsers.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PMWte55jcfTbjieG4nHD8C
Firefox WASM execution is ~2x slower than Chromium, so apply a 2.5x
multiplier to all performance budget assertions when running on Firefox.
Increase the manifest retry test timeout to 60s to accommodate Firefox's
slower compiler initialization after retry.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PMWte55jcfTbjieG4nHD8C
@ktjn
ktjn merged commit b05546e into main Jul 23, 2026
7 of 8 checks passed
@ktjn
ktjn deleted the claude/ci-failures-rb8zwi branch July 23, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants