Make definition lookup mode configurable#45
Open
petr-popov wants to merge 3 commits intoktnyt:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change adds per-server
definition_modetocclspconfig.Supported values:
symbol(default): existing behavior usingsymbol_nameand optionalsymbol_kindposition: direct go-to-definition usinglineandcharacterMotivation
The existing name-based
find_definitionbehavior works well for some languages and LLM workflows, but it does not work well for Kotlin/Java go-to-definition from a usage site. In those cases, definition lookup should startfrom a concrete cursor position instead of trying to resolve a declaration by name inside the current file.
Changes
definition_mode?: "position" | "symbol"to server configsymbolfor backward compatibilityLSPClient.getDefinitionMode(filePath)find_definitionto branch by serverdefinition_modepositionandsymbolmodesValidation
npx tsc --noEmitfind_definitionfrom usage positions withdefinition_mode: "position"