-
Notifications
You must be signed in to change notification settings - Fork 58
Clarify excess config behavior preserves running aggregator #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -99,7 +99,9 @@ kubectl get syslogngconfig example -o jsonpath='{.status}' | jq . | |
| } | ||
| ``` | ||
|
|
||
| If there is a conflict, the controller adds a problem to both resources so that both the operations team and the tenant users can notice the problem. For example, if a `syslogNGConfig` is already registered to a `Logging` resource and you create another `syslogNGConfig` resource in the same namespace, then the first `syslogNGConfig` is left intact, while the second one should have the following status: | ||
| If there is a conflict, the controller adds a problem to both resources so that both the operations team and the tenant users can notice the problem. The previously-associated `SyslogNGConfig` continues to operate normally, and log forwarding remains uninterrupted while you resolve the excess configuration. | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added clarification that the aggregator keeps running based on PR #2232 which fixes the bug where creating a second |
||
|
|
||
| For example, if a `SyslogNGConfig` is already registered to a `Logging` resource and you create another `SyslogNGConfig` resource in the same namespace, the first `SyslogNGConfig` is left intact and its aggregator keeps running, while the second one should have the following status: | ||
|
|
||
| ```shell | ||
| kubectl get syslogngconfig example2 -o jsonpath='{.status}' | jq . | ||
|
|
@@ -128,6 +130,8 @@ kubectl get logging example -o jsonpath='{.status}' | jq . | |
| } | ||
| ``` | ||
|
|
||
| To resolve this conflict, delete the excess `SyslogNGConfig` resource. The active aggregator will continue running throughout. | ||
|
|
||
| ## Volume mount for buffering | ||
|
|
||
| The following example sets a volume mount that syslog-ng can use for buffering messages on the disk (if {{% xref "/docs/configuration/plugins/syslog-ng-outputs/disk_buffer.md" %}} is configured in the output). | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added clarification that the aggregator keeps running based on PR #2232 which fixes the bug where creating a second
FluentdConfigwould tear down the running aggregator. The fix inrepository.gopreserves the previously-associated configuration recorded inLogging.Status.FluentdConfigName.Source: kube-logging/logging-operator#2232