fix: resolve file routing crashes by correcting MOT17 directory mismatches#398
fix: resolve file routing crashes by correcting MOT17 directory mismatches#398rakshaak29 wants to merge 12 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rakshaak29 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubeedge-bot
added
the
size/M
rakshaak29
force-pushed
the
fix/mot17-filepaths
branch
2 times, most recently
from
b140c4e to
69b4339
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request improves the portability and robustness of several LLM and tracking examples by replacing hardcoded absolute paths with relative ones, updating device selection logic to support Apple Silicon (MPS), and fixing typos. It also adds safety checks to prevent division-by-zero errors in evaluation metrics. A review comment suggests using zip in the accuracy calculation to avoid potential index errors when comparing prediction and ground truth lists.
kubeedge-bot
added
the
do-not-merge/invalid-commit-message
Signed-off-by: Juntao Zhang <juntaozhang22@m.fudan.edu.cn> Signed-off-by: rakshaak29 <rakshak29@gmail.com>
…ix basemodel - Replace all hardcoded absolute paths with relative paths in YAML configs - Use HuggingFace Hub model ID (Qwen/Qwen2.5-0.5B-Instruct) instead of local path - Add missing preprocess() method to BaseModel (required by sedna) - Add MPS/CPU device detection for macOS compatibility - Update .gitignore to exclude local dev artifacts Signed-off-by: rakshaak29 <rakshak29@gmail.com>
Signed-off-by: rakshaak29 <rakshak29@gmail.com>
Signed-off-by: rakshaak29 <rakshak29@gmail.com>
Signed-off-by: rakshaak29 <rakshak29@gmail.com>
Signed-off-by: rakshaak29 <rakshak29@gmail.com>
…r torch versions Signed-off-by: rakshaak29 <rakshak29@gmail.com>
…ainability Signed-off-by: rakshaak29 <rakshak29@gmail.com>
Signed-off-by: rakshaak29 <rakshak29@gmail.com>
… device Signed-off-by: rakshaak29 <rakshak29@gmail.com>
…ics calculation Signed-off-by: rakshaak29 <rakshak29@gmail.com>
Signed-off-by: rakshaak29 <rakshak29@gmail.com>
rakshaak29
force-pushed
the
fix/mot17-filepaths
branch
from
24f4177 to
594e3e9
Compare
kubeedge-bot
added
size/L
3 participants
Description
This Pull Request resolves a configuration bug in the MOT17 Pedestrian Tracking example where the
tracking_jobandreid_jobbenchmarking orchestrators instantly crash.Changes Included:
tracking_job.yamlandreid_job.yamlinternal routing paths were strictly referencing the outdated string./examples/pedestrian_tracking/.... I've updated the relative URLs resolving them correctly to./examples/MOT17/multiedge_inference_bench/...to reflect the actual repository tree. Runningianvs -f ...no longer throws aFileNotFoundError.Related Issue
tracking_job&reid_jobfail to launch due to nested directory mismatches #397