fix(cloud_VLA_finetune): rename requirement.txt to requirements.txt a…#428
fix(cloud_VLA_finetune): rename requirement.txt to requirements.txt a…#428tushar743-ui wants to merge 1 commit into
Conversation
|
Welcome @tushar743-ui! It looks like this is your first PR to kubeedge/ianvs 🎉 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tushar743-ui The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
This PR aims to make the cloud_VLA_finetune/singletask_learning_bench example installable via the standard pip install -r requirements.txt workflow (as referenced in the example's README) and to relax the protobuf pin so it doesn't conflict with the Ianvs core runtime. It addresses one of the unchecked examples tracked in issue #194.
Changes:
- Adds a
requirements.txtfile mirroring the previousrequirement.txtcontents. - Loosens the
protobufpin from==6.32.1to>=3.20.0,<4.0.0for compatibility with Ianvs core. - Intended rename of
requirement.txtis not completed — the old file still exists in the repo.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…nd fix protobuf version conflict - Renamed requirement.txt to requirements.txt to follow standard Python conventions and ensure compatibility with automated tooling and CI - Fixed protobuf version from ==6.32.1 to >=3.20.0,<4.0.0 to resolve conflict with Ianvs core runtime which requires protobuf<=3.20.3 Signed-off-by: tushar743-ui <tusharpatle743@gmail.com>
a920d51 to
524a34a
Compare
There was a problem hiding this comment.
Code Review
This pull request adds a requirements.txt file for the singletask_learning_bench example. The review feedback identifies a critical issue where several dependencies specify non-existent versions or incorrect package names (e.g., cffi, numpy, and scikit-learn), which will prevent the environment from being installed correctly.
| annotated-types==0.7.0 | ||
| anyio==4.11.0 | ||
| argon2-cffi==25.1.0 | ||
| argon2-cffi-bindings==25.1.0 | ||
| certifi==2025.8.3 | ||
| cffi==2.0.0 | ||
| charset-normalizer==3.4.3 | ||
| click==8.3.0 | ||
| colorlog==6.9.0 | ||
| contourpy==1.3.2 | ||
| cycler==0.12.1 | ||
| exceptiongroup==1.3.0 | ||
| fastapi==0.117.1 | ||
| fonttools==4.60.0 | ||
| h11==0.16.0 | ||
| idna==3.10 | ||
| joblib==1.5.2 | ||
| kiwisolver==1.4.9 | ||
| matplotlib==3.10.6 | ||
| minio==7.2.16 | ||
| ml_dtypes==0.5.3 | ||
| numpy==2.2.6 | ||
| onnx==1.19.0 | ||
| opencv-python-headless==4.10.0.84 | ||
| packaging==25.0 | ||
| pandas==2.3.2 | ||
| pillow==11.3.0 | ||
| prettytable==2.5.0 | ||
| protobuf>=3.20.0,<4.0.0 | ||
| pycocotools==2.0.10 | ||
| pycparser==2.23 | ||
| pycryptodome==3.23.0 | ||
| pydantic==2.11.9 | ||
| pydantic_core==2.33.2 | ||
| pyparsing==3.2.5 | ||
| python-dateutil==2.9.0.post0 | ||
| pytz==2025.2 | ||
| PyYAML==6.0.2 | ||
| requests==2.32.5 | ||
| scikit-learn==1.7.2 | ||
| scipy==1.15.3 | ||
| six==1.17.0 | ||
| sniffio==1.3.1 | ||
| starlette==0.48.0 | ||
| tenacity==9.1.2 | ||
| threadpoolctl==3.6.0 | ||
| tqdm==4.67.1 | ||
| typing-inspection==0.4.1 | ||
| typing_extensions==4.15.0 | ||
| tzdata==2025.2 | ||
| urllib3==2.5.0 | ||
| uvicorn==0.37.0 | ||
| watchdog==6.0.0 | ||
| wcwidth==0.2.14 | ||
| websockets==15.0.1 |
There was a problem hiding this comment.
Several dependencies in this file specify non-existent versions or incorrect package names, which will cause installation failures (e.g., when running pip install -r requirements.txt).
Examples of invalid entries:
cffi==2.0.0: The current version is 1.17.x; version 2.0.0 does not exist.numpy==2.2.6: The current stable version is 2.1.x; 2.2.6 is not yet released.typing-inspection==0.4.1: This package name appears to be a typo fortyping-inspect.argon2-cffi==25.1.0: The current version is 23.1.x.onnx==1.19.0: The current version is 1.17.x.scikit-learn==1.7.2: The current version is 1.5.x/1.6.x.
These invalid entries will prevent the environment from being set up correctly. Please update the file with valid, existing package versions and names from PyPI.
What type of PR is this?
/kind bug
What this PR does / why we need it:
The cloud_VLA_finetune example had two issues preventing clean setup by contributors:
Which issue(s) this PR fixes:
Fixes #194