Skip to content

fix(cloud_VLA_finetune): rename requirement.txt to requirements.txt a…#428

Open
tushar743-ui wants to merge 1 commit into
kubeedge:mainfrom
tushar743-ui:fix/cloud-vla-finetune-requirements
Open

fix(cloud_VLA_finetune): rename requirement.txt to requirements.txt a…#428
tushar743-ui wants to merge 1 commit into
kubeedge:mainfrom
tushar743-ui:fix/cloud-vla-finetune-requirements

Conversation

@tushar743-ui
Copy link
Copy Markdown

  • Renamed requirement.txt to requirements.txt to follow standard Python conventions and ensure compatibility with automated tooling and CI
  • Fixed protobuf version from ==6.32.1 to >=3.20.0,<4.0.0 to resolve conflict with Ianvs core runtime which requires protobuf<=3.20.3

What type of PR is this?

/kind bug

What this PR does / why we need it:
The cloud_VLA_finetune example had two issues preventing clean setup by contributors:

  1. The requirements file was named requirement.txt instead of the standard requirements.txt, breaking any automated tooling, CI scripts, or install workflows that look for the conventional filename.
  2. protobuf==6.32.1 was hard pinned, which directly conflicts with the Ianvs core runtime compatibility boundary of protobuf<=3.20.3 documented across other examples. This causes silent runtime breakage when installing alongside Ianvs core dependencies. Changed to protobuf>=3.20.0,<4.0.0 to satisfy both constraints.

Which issue(s) this PR fixes:

Fixes #194

Copilot AI review requested due to automatic review settings May 16, 2026 11:05
@kubeedge-bot kubeedge-bot added the kind/bug Categorizes issue or PR as related to a bug. label May 16, 2026
@kubeedge-bot
Copy link
Copy Markdown
Collaborator

Welcome @tushar743-ui! It looks like this is your first PR to kubeedge/ianvs 🎉

@kubeedge-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tushar743-ui
To complete the pull request process, please assign jaypume after the PR has been reviewed.
You can assign the PR to them by writing /assign @jaypume in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot requested review from Poorunga and hsj576 May 16, 2026 11:05
@kubeedge-bot kubeedge-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 16, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to make the cloud_VLA_finetune/singletask_learning_bench example installable via the standard pip install -r requirements.txt workflow (as referenced in the example's README) and to relax the protobuf pin so it doesn't conflict with the Ianvs core runtime. It addresses one of the unchecked examples tracked in issue #194.

Changes:

  • Adds a requirements.txt file mirroring the previous requirement.txt contents.
  • Loosens the protobuf pin from ==6.32.1 to >=3.20.0,<4.0.0 for compatibility with Ianvs core.
  • Intended rename of requirement.txt is not completed — the old file still exists in the repo.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…nd fix protobuf version conflict

- Renamed requirement.txt to requirements.txt to follow standard Python
  conventions and ensure compatibility with automated tooling and CI
- Fixed protobuf version from ==6.32.1 to >=3.20.0,<4.0.0 to resolve
  conflict with Ianvs core runtime which requires protobuf<=3.20.3

Signed-off-by: tushar743-ui <tusharpatle743@gmail.com>
@tushar743-ui tushar743-ui force-pushed the fix/cloud-vla-finetune-requirements branch from a920d51 to 524a34a Compare May 16, 2026 11:07
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a requirements.txt file for the singletask_learning_bench example. The review feedback identifies a critical issue where several dependencies specify non-existent versions or incorrect package names (e.g., cffi, numpy, and scikit-learn), which will prevent the environment from being installed correctly.

Comment on lines +1 to +55
annotated-types==0.7.0
anyio==4.11.0
argon2-cffi==25.1.0
argon2-cffi-bindings==25.1.0
certifi==2025.8.3
cffi==2.0.0
charset-normalizer==3.4.3
click==8.3.0
colorlog==6.9.0
contourpy==1.3.2
cycler==0.12.1
exceptiongroup==1.3.0
fastapi==0.117.1
fonttools==4.60.0
h11==0.16.0
idna==3.10
joblib==1.5.2
kiwisolver==1.4.9
matplotlib==3.10.6
minio==7.2.16
ml_dtypes==0.5.3
numpy==2.2.6
onnx==1.19.0
opencv-python-headless==4.10.0.84
packaging==25.0
pandas==2.3.2
pillow==11.3.0
prettytable==2.5.0
protobuf>=3.20.0,<4.0.0
pycocotools==2.0.10
pycparser==2.23
pycryptodome==3.23.0
pydantic==2.11.9
pydantic_core==2.33.2
pyparsing==3.2.5
python-dateutil==2.9.0.post0
pytz==2025.2
PyYAML==6.0.2
requests==2.32.5
scikit-learn==1.7.2
scipy==1.15.3
six==1.17.0
sniffio==1.3.1
starlette==0.48.0
tenacity==9.1.2
threadpoolctl==3.6.0
tqdm==4.67.1
typing-inspection==0.4.1
typing_extensions==4.15.0
tzdata==2025.2
urllib3==2.5.0
uvicorn==0.37.0
watchdog==6.0.0
wcwidth==0.2.14
websockets==15.0.1
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Several dependencies in this file specify non-existent versions or incorrect package names, which will cause installation failures (e.g., when running pip install -r requirements.txt).

Examples of invalid entries:

  • cffi==2.0.0: The current version is 1.17.x; version 2.0.0 does not exist.
  • numpy==2.2.6: The current stable version is 2.1.x; 2.2.6 is not yet released.
  • typing-inspection==0.4.1: This package name appears to be a typo for typing-inspect.
  • argon2-cffi==25.1.0: The current version is 23.1.x.
  • onnx==1.19.0: The current version is 1.17.x.
  • scikit-learn==1.7.2: The current version is 1.5.x/1.6.x.

These invalid entries will prevent the environment from being set up correctly. Please update the file with valid, existing package versions and names from PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Track of Runnable Examples

3 participants