Skip to content

Fix: "Clear all filters" appear in Model performance view#2683

Open
Philip-Carneiro wants to merge 1 commit into
kubeflow:mainfrom
Philip-Carneiro:fix/clear-all-filters-performance-view
Open

Fix: "Clear all filters" appear in Model performance view#2683
Philip-Carneiro wants to merge 1 commit into
kubeflow:mainfrom
Philip-Carneiro:fix/clear-all-filters-performance-view

Conversation

@Philip-Carneiro
Copy link
Copy Markdown
Contributor

Description

When in Model Catalog and select a sidebar filter and after that, enables the Model performance view, the "Clear all filters" appear.
image

After
non-PF:
image

PF:
image

How Has This Been Tested?

Cypress added to verify if follow the steps to reproduce the bug if the "Clear all filters" text appear

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Signed-off-by: Philip Colares Carneiro <philip.colares@gmail.com>
@google-oss-prow google-oss-prow Bot requested a review from chambridge May 7, 2026 15:37
@google-oss-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yuliakrimerman for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot requested a review from fege May 7, 2026 15:37
@YuliaKrimerman
Copy link
Copy Markdown
Contributor

/retest

@ppadti
Copy link
Copy Markdown
Contributor

ppadti commented May 12, 2026

@Philip-Carneiro This PR LGTM, but looks like this branch is out of date - can we just rebase, before merging?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants