fix(manifests): upstream Istio AuthorizationPolicy from kubeflow/manifests#2708
Closed
jonburdo wants to merge 1 commit into
Closed
fix(manifests): upstream Istio AuthorizationPolicy from kubeflow/manifests#2708jonburdo wants to merge 1 commit into
jonburdo wants to merge 1 commit into
Conversation
…fests Port the AuthorizationPolicy rules added in kubeflow/manifests#3318 back to this repo so future manifest syncs don't regress the fix. Replaces the permissive allow-all rule with proper Kubeflow-aware rules: - Allow requests from the Istio ingress gateway (authenticated by oauth2-proxy) - Allow internal requests with a valid K8s JWT but block identity spoofing via kubeflow-userid header Relates-to: kubeflow/manifests#3457 Relates-to: kubeflow/manifests#3318 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Jon Burdo <jon@jonburdo.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
Author
|
I didn't realize, there was already a PR for this 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port the AuthorizationPolicy rules added in kubeflow/manifests#3318 back to this repo so future manifest syncs don't regress the fix.
Replaces the permissive allow-all rule with proper Kubeflow-aware rules:
Relates-to: kubeflow/manifests#3457
Relates-to: kubeflow/manifests#3318
Description
How Has This Been Tested?
Merge criteria:
DCOcheck)ok-to-testhas been added to the PR.If you have UI changes