Honor stderrthreshold when logtostderr is enabled#794
Open
pierluigilenoci wants to merge 1 commit intokubeflow:masterfrom
Open
Honor stderrthreshold when logtostderr is enabled#794pierluigilenoci wants to merge 1 commit intokubeflow:masterfrom
pierluigilenoci wants to merge 1 commit intokubeflow:masterfrom
Conversation
Opt into the fixed klog behavior by setting legacy_stderr_threshold_behavior=false after klog.InitFlags(). Ref: kubernetes/klog#212, kubernetes/klog#432 Signed-off-by: Pierluigi Lenoci <pierluigi.lenoci@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Author
|
Hi @tenzen-y, @terrytangyuan, @alculquicondor -- would you be willing to review? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Opt into the new klog behavior so that
-stderrthresholdis honored even when-logtostderr=true(the default). Setstderrthreshold=INFOto preserve backward compatibility.Background
When
-logtostderr=true,-stderrthresholdwas ignored -- all logs went to stderr. Fixed in kubernetes/klog#432 (v2.140.0+), but projects must opt in.Changes
flag.Set("legacy_stderr_threshold_behavior", "false")andflag.Set("stderrthreshold", "INFO")afterklog.InitFlags()incmd/mpi-operator/main.gok8s.io/klog/v2from v2.130.1 to v2.140.0References