Skip to content

feat(trainer): improve DX for LocalProcessBackend missing runtime error #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zannensk wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −2
Open

feat(trainer): improve DX for LocalProcessBackend missing runtime error #424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion kubeflow/trainer/backends/localprocess/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,11 @@ def train(
options: list | None = None,
) -> str:
if runtime is None:
raise ValueError("Runtime must be provided for LocalProcessBackend")
available_runtimes = [r.name for r in local_runtimes]
raise ValueError(
f"Runtime must be provided for LocalProcessBackend. "
f"Available runtimes are: {available_runtimes}."
)
if isinstance(runtime, str):
runtime = self.get_runtime(runtime)

Expand Down
5 changes: 4 additions & 1 deletion kubeflow/trainer/backends/localprocess/backend_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,10 @@ def test_train(local_backend, mock_train_environment, test_case):
if "rejects kubernetes" in test_case.name:
assert "not compatible with" in error_msg
elif "without runtime" in test_case.name:
assert "Runtime must be provided" in error_msg
assert (
"Runtime must be provided for LocalProcessBackend. Available runtimes are:"
in error_msg
)
elif "without custom trainer" in test_case.name:
assert "CustomTrainer must be set" in error_msg
else:
Expand Down
Loading