fix(hub): add params to register_model()#440
Open
1Ayush-Petwal wants to merge 1 commit intokubeflow:mainfrom
Open
fix(hub): add params to register_model()#4401Ayush-Petwal wants to merge 1 commit intokubeflow:mainfrom
1Ayush-Petwal wants to merge 1 commit intokubeflow:mainfrom
Conversation
…ster_model Signed-off-by: 1Ayush-Petwal <ayushpetwal.0105@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds missing storage/auth-related kwargs to ModelRegistryClient.register_model() and forwards them to the upstream ModelRegistry.register_model() to match the existing docstring and fix silent parameter dropping (Fixes #439).
Changes:
- Extend
register_model()signature to acceptstorage_key,storage_path, andservice_account_name. - Document the new kwargs in the docstring.
- Forward the new kwargs to the underlying
ModelRegistry.register_model()call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
**What this PR does **:
Adds storage_key, storage_path, and service_account_name kwargs to
ModelRegistryClient.register_model(). These were documented in the docstring but silently dropped — they are now forwarded to the upstreamModelRegistry.register_model().Which issue(s) this PR fixes :
Fixes #439
Checklist: