Skip to content

fix(hub): add params to register_model()#440

Open
1Ayush-Petwal wants to merge 1 commit intokubeflow:mainfrom
1Ayush-Petwal:fix/hub-register-model-storage-params
Open

fix(hub): add params to register_model()#440
1Ayush-Petwal wants to merge 1 commit intokubeflow:mainfrom
1Ayush-Petwal:fix/hub-register-model-storage-params

Conversation

@1Ayush-Petwal
Copy link
Copy Markdown

**What this PR does **:

Adds storage_key, storage_path, and service_account_name kwargs to ModelRegistryClient.register_model(). These were documented in the docstring but silently dropped — they are now forwarded to the upstream ModelRegistry.register_model().

Which issue(s) this PR fixes :

Fixes #439

Checklist:

  • Docs included if any changes are user facing

…ster_model

Signed-off-by: 1Ayush-Petwal <ayushpetwal.0105@gmail.com>
Copilot AI review requested due to automatic review settings March 30, 2026 12:39
@google-oss-prow google-oss-prow bot requested review from fege and szaher March 30, 2026 12:39
@google-oss-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jonburdo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds missing storage/auth-related kwargs to ModelRegistryClient.register_model() and forwards them to the upstream ModelRegistry.register_model() to match the existing docstring and fix silent parameter dropping (Fixes #439).

Changes:

  • Extend register_model() signature to accept storage_key, storage_path, and service_account_name.
  • Document the new kwargs in the docstring.
  • Forward the new kwargs to the underlying ModelRegistry.register_model() call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(hub): ModelRegistryClient.register_model() call drops 3 parameters

2 participants