chore(test): add unit tests for trainingruntime and trainjob utilities#3370
Open
codewithyug06 wants to merge 1 commit intokubeflow:masterfrom
Open
chore(test): add unit tests for trainingruntime and trainjob utilities#3370codewithyug06 wants to merge 1 commit intokubeflow:masterfrom
codewithyug06 wants to merge 1 commit intokubeflow:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
🎉 Welcome to the Kubeflow Trainer! 🎉 Thanks for opening your first PR! We're happy to have you as part of our community 🚀 Here's what happens next:
Join the community:
Feel free to ask questions in the comments if you need any help or clarification! |
Fixes kubeflow#3152 pkg/util/trainingruntime (0 percent to 100 percent coverage): - New trainingruntime_test.go with 8 cases for IsSupportDeprecated covering nil, empty, absent key, wrong value, empty value, correct deprecated, multiple labels, and partial match edge case. pkg/util/trainjob (extended): - TestRuntimeRefIsClusterTrainingRuntime: 4 new edge cases added covering wrong APIGroup, nil APIGroup, nil Kind, both nil. - TestIsTrainJobFinished: 6 new cases covering all condition states. - Added metav1 import required for Condition status constants. Signed-off-by: Yugendhar S <yugendhars06@gmail.com>
codewithyug06
force-pushed
the
test/add-unit-tests-trainingruntime-util
branch
from
cca929a to
8dd6324
Compare
codewithyug06
changed the title
codewithyug06
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3152
What this PR does
Adds missing unit test coverage for two utility packages as part of #3152.
Changes
pkg/util/trainingruntime/trainingruntime_test.go (NEW FILE)
TestIsSupportDeprecated: 8 test cases covering nil labels, empty labels,absent key, wrong value, empty value, correct deprecated value, multiple
labels with deprecated, and partial string match edge case.
pkg/util/trainjob/trainjob_test.go (EXTENDED)
TestRuntimeRefIsClusterTrainingRuntime: 4 new edge cases covering wrongAPIGroup, nil APIGroup, nil Kind, and both nil.
TestIsTrainJobFinished: 6 new cases covering Complete=True, Failed=True,no conditions, Complete=False, Failed=False, and both true.
metav1import required for Condition status constants.Testing
go test ./pkg/util/trainingruntime/... -v → PASS (8/8 subtests)
go test ./pkg/util/trainjob/... -v → PASS (14/14 subtests)
Checklist