-
Notifications
You must be signed in to change notification settings - Fork 946
fix(operator): Scope MPI ConfigMap and Secret watches to owned objects #3377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
beep-boopp
wants to merge
1
commit into
kubeflow:master
Choose a base branch
from
beep-boopp:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,6 +29,7 @@ import ( | |
|
|
||
| "golang.org/x/crypto/ssh" | ||
| corev1 "k8s.io/api/core/v1" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| apiruntime "k8s.io/apimachinery/pkg/runtime" | ||
| "k8s.io/apimachinery/pkg/util/validation/field" | ||
| corev1ac "k8s.io/client-go/applyconfigurations/core/v1" | ||
|
|
@@ -38,6 +39,7 @@ import ( | |
| "sigs.k8s.io/controller-runtime/pkg/cache" | ||
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
| "sigs.k8s.io/controller-runtime/pkg/handler" | ||
| "sigs.k8s.io/controller-runtime/pkg/predicate" | ||
| "sigs.k8s.io/controller-runtime/pkg/webhook/admission" | ||
|
|
||
| configapi "github.com/kubeflow/trainer/v2/pkg/apis/config/v1alpha1" | ||
|
|
@@ -218,19 +220,27 @@ func (m *MPI) EnforceMLPolicy(info *runtime.Info, trainJob *trainer.TrainJob) er | |
| func (m *MPI) ReconcilerBuilders() []runtime.ReconcilerBuilder { | ||
| return []runtime.ReconcilerBuilder{ | ||
| func(b *builder.Builder, cl client.Client, cache cache.Cache) *builder.Builder { | ||
| return b.Watches( | ||
| return b.WatchesMetadata( | ||
| &corev1.ConfigMap{}, | ||
| handler.EnqueueRequestForOwner( | ||
| m.client.Scheme(), m.client.RESTMapper(), &trainer.TrainJob{}, handler.OnlyControllerOwner(), | ||
| ), | ||
| builder.WithPredicates(predicate.NewPredicateFuncs(func(obj client.Object) bool { | ||
| _, ok := obj.GetLabels()[constants.LabelJobName] | ||
| return ok | ||
| })), | ||
| ) | ||
|
Comment on lines
+223
to
232
|
||
| }, | ||
| func(b *builder.Builder, cl client.Client, cache cache.Cache) *builder.Builder { | ||
| return b.Watches( | ||
| return b.WatchesMetadata( | ||
| &corev1.Secret{}, | ||
| handler.EnqueueRequestForOwner( | ||
| m.client.Scheme(), m.client.RESTMapper(), &trainer.TrainJob{}, handler.OnlyControllerOwner(), | ||
| ), | ||
| builder.WithPredicates(predicate.NewPredicateFuncs(func(obj client.Object) bool { | ||
| _, ok := obj.GetLabels()[constants.LabelJobName] | ||
| return ok | ||
| })), | ||
| ) | ||
| }, | ||
| } | ||
|
|
@@ -244,7 +254,9 @@ func (m *MPI) Build(ctx context.Context, info *runtime.Info, trainJob *trainer.T | |
| var objects []apiruntime.ApplyConfiguration | ||
|
|
||
| // SSHAuthSecret is immutable. | ||
| if err := m.client.Get(ctx, client.ObjectKey{Name: sshAuthSecretName(trainJob.Name), Namespace: trainJob.Namespace}, &corev1.Secret{}); err != nil { | ||
| partialSecret := &metav1.PartialObjectMetadata{} | ||
| partialSecret.SetGroupVersionKind(corev1.SchemeGroupVersion.WithKind("Secret")) | ||
| if err := m.client.Get(ctx, client.ObjectKey{Name: sshAuthSecretName(trainJob.Name), Namespace: trainJob.Namespace}, partialSecret); err != nil { | ||
| if client.IgnoreNotFound(err) != nil { | ||
| return nil, err | ||
| } | ||
|
|
@@ -275,6 +287,9 @@ func (m *MPI) buildSSHAuthSecret(trainJob *trainer.TrainJob) (*corev1ac.SecretAp | |
| return nil, err | ||
| } | ||
| return corev1ac.Secret(sshAuthSecretName(trainJob.Name), trainJob.Namespace). | ||
| WithLabels(map[string]string{ | ||
| constants.LabelJobName: trainJob.Name, | ||
| }). | ||
| WithType(corev1.SecretTypeSSHAuth). | ||
| WithData(map[string][]byte{ | ||
| corev1.SSHAuthPrivateKey: privatePEM, | ||
|
|
@@ -310,6 +325,9 @@ func (m *MPI) buildHostFileConfigMap(info *runtime.Info, trainJob *trainer.Train | |
| } | ||
| } | ||
| return corev1ac.ConfigMap(fmt.Sprintf("%s%s", trainJob.Name, constants.MPIHostfileConfigMapSuffix), trainJob.Namespace). | ||
| WithLabels(map[string]string{ | ||
| constants.LabelJobName: trainJob.Name, | ||
| }). | ||
| WithData(map[string]string{ | ||
| constants.MPIHostfileName: hostFile.String(), | ||
| }). | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new label-based predicate will drop events for existing MPI-owned Secrets/ConfigMaps created before this change (they have owner refs but won’t have the new label), so deletions/updates of those objects may no longer trigger TrainJob reconciliation after an upgrade.