Skip to content

chore(api): rename CertManagement webhook fields to generic names#3386

Open
tariq-hasan wants to merge 1 commit intokubeflow:masterfrom
tariq-hasan:chore/rename-certmanagement-config-fields
Open

chore(api): rename CertManagement webhook fields to generic names#3386
tariq-hasan wants to merge 1 commit intokubeflow:masterfrom
tariq-hasan:chore/rename-certmanagement-config-fields

Conversation

@tariq-hasan
Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Renames the CertManagement configuration fields from webhook-specific names to generic names, since the TLS certificate is used by the metrics server and the status server in addition to webhooks.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #3327

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com>
Copilot AI review requested due to automatic review settings March 24, 2026 00:20
@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andreyvelich for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link
Copy Markdown

🎉 Welcome to the Kubeflow Trainer! 🎉

Thanks for opening your first PR! We're happy to have you as part of our community 🚀

Here's what happens next:

  • If you haven't already, please check out our Contributing Guide for repo-specific guidelines and the Kubeflow Contributor Guide for general community standards.
  • Our team will review your PR soon! cc @kubeflow/kubeflow-trainer-team

Join the community:

Feel free to ask questions in the comments if you need any help or clarification!
Thanks again for contributing to Kubeflow! 🙏

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR renames the CertManagement configuration fields from webhook-specific names (WebhookServiceName and WebhookSecretName) to generic names (ServiceName and SecretName) throughout the codebase, addressing issue #3327. This change is necessary because the TLS certificate is used not only by admission webhooks but also by the metrics server and status server.

Changes:

  • Renamed struct fields and JSON tags in the CertManagement configuration type to use generic names
  • Updated all usages of these fields across the codebase including the cert utility, trainjobstatus plugin, and main controller manager
  • Updated documentation comments to clarify that the certificate serves multiple components
  • Updated all configuration files, templates, and test fixtures to use the new field names

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkg/apis/config/v1alpha1/configuration_types.go Updated CertManagement struct fields and documentation to use generic names
pkg/util/cert/cert.go Updated Config struct to use the new field names
cmd/trainer-controller-manager/main.go Updated references to use new field names when calling cert.ManageCerts
pkg/runtime/framework/plugins/trainjobstatus/trainjobstatus.go Updated usage and removed obsolete TODO comment
pkg/apis/config/v1alpha1/defaults.go Updated default value setting to use new field names
pkg/config/config_test.go Updated all test fixtures and configuration examples
pkg/runtime/framework/plugins/trainjobstatus/trainjobstatus_test.go Updated test configurations
manifests/base/manager/controller_manager_config.yaml Updated manifest YAML
charts/kubeflow-trainer/values.yaml Updated Helm values
charts/kubeflow-trainer/templates/manager/configmap.yaml Updated Helm template
charts/kubeflow-trainer/tests/manager/configmap_test.yaml Updated Helm test assertions
charts/kubeflow-trainer/README.md Updated auto-generated documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename CertManagement.WebhookServiceName and CertManagement.WebhookSecretName config settings

2 participants