Add Apache License 2.0 headers to fluent source files#4831
Conversation
Fixes #4819: The client-java-api-fluent sources JAR was missing license headers because spotless was completely skipped for the fluent module. - Add license headers to all 1457 generated fluent source files - Update fluent/pom.xml to enable spotless licenseHeader check only (using combine.self=override to avoid inheriting groovy/formatter) - Update fluent-gen/generate.sh to run spotless:apply after regeneration
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Copilot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
2c74f83 to
c4cfd8b
Compare
|
Invalid commit message issues detected Invalid commit messagesKeywords which can automatically close issues and hashtag(#) mentions are not allowed.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The
client-java-api-fluentsources JAR contained no license headers on any of its ~1,457 generated Java files because the fluent module had spotless entirely disabled (<skip>true</skip>).Changes
fluent/src/main/java/**/*.java— Added Apache License 2.0 header to all 1,457 generated fluent source files.fluent/pom.xml— Replaced the spotless<skip>true</skip>with a targeted license-header-only configuration usingcombine.self="override"to avoid inheriting the parent's full spotless config (Google Java Format, groovy formatter, wildcard-import checks) that would break generated code style.fluent-gen/generate.sh— Addedmvn spotless:applyafter code generation so future regenerations automatically pick up license headers.The resulting spotless config in
fluent/pom.xml: