🌱 KAL: Enable low effort linters#3161
Conversation
Signed-off-by: Lennart Jern <lennart.jern@est.tech>
This fixes all automatically fixable issues detected by the commentstart linter in v1beta2. Signed-off-by: Lennart Jern <lennart.jern@est.tech>
Fix the rest of the commentstart issues manually. Signed-off-by: Lennart Jern <lennart.jern@est.tech>
Enable the linter and fix the issues it reported. Signed-off-by: Lennart Jern <lennart.jern@est.tech>
Ensure all status fields have only optional first children. Signed-off-by: Lennart Jern <lennart.jern@est.tech>
k8s-ci-robot
added
the
do-not-merge/hold
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
size/XXL
|
/retest |
nikParasyr
left a comment
nikParasyr
left a comment
There was a problem hiding this comment.
/lgtm
( if those are mostly automatically fixed, wonder if we can wait for #3155 as it will create quite some conflicts )
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nikParasyr The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Yes, we definitely can! Leaving hold in place. I'll try to get some time for reviewing #3155 |
4 participants
What this PR does / why we need it:
Enable kube-api-linters that doesn't require much effort. These are mostly non-controversial, non-breaking and the issues they report can to a large extent be automatically fixed.
I have split this up in separate commits to make it easier to review. Especially the automatic doc string fixes are large but trivial.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #3131
Special notes for your reviewer:
TODOs:
/hold