Update manager.yaml to modify nodeSelector and tolerations

[rohitkbc]

Description

Removed nodeSelector for control-plane and updated to use default tolerations.

Related Issue

Fixes #98

Type of Change

/kind feature

Testing

Checklist

• make test passes
• make lint passes

Does this PR introduce a user-facing change?

allow placement of controller on any node with broad tolerations.

[netlify]

✅ Deploy Preview for node-readiness-controller canceled.

Name	Link
🔨 Latest commit	d4ff2cc
🔍 Latest deploy log	https://app.netlify.com/projects/node-readiness-controller/deploys/698e038da0015600087e7fd8

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rohitkbc
Once this PR has been reviewed and has the lgtm label, please assign haircommander for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @rohitkbc!

It looks like this is your first PR to kubernetes-sigs/node-readiness-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/node-readiness-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @rohitkbc. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ajaysundark]

/ok-to-test

[ajaysundark]

Hi @rohitkbc, Thanks for your PR.

Did you get a chance to try docs/TEST_README.md for testing your changes?

IIRC, the test setup currently may have assumptions on where the controller is deployed (on the controlplane).
We may need to confirm if this needs any additional changes. It'd likely also be applicable to e2e tests

[Priyankasaggu11929]

Let's add a breadcrumb here for future -

Suggested change

	tolerations:
	# TODO: In the future, this could be replaced with tolerate only readiness.k8s.io/* taints specifically, when wildcard support is available in K8s.
	# (ref: https://github.com/kubernetes/enhancements/issues/5500)
	tolerations:

[ajaysundark]

/assign @rohitkbc

[ajaysundark]

Hi @rohitkbc, Thanks for your PR.

Did you get a chance to try docs/TEST_README.md for testing your changes?

IIRC, the test setup currently may have assumptions on where the controller is deployed (on the controlplane). We may need to confirm if this needs any additional changes. It'd likely also be applicable to e2e tests

Hi @rohitkbc, did you get a chance to try this?

[rohitkbc]

Hi @ajaysundark,

Apologies for the delayed response. I was occupied with office work and am still tied up, so I couldn’t work on it.