Skip to content

⚠️ Remove per node-data from rule status#131

Open
Karthik-K-N wants to merge 1 commit intokubernetes-sigs:mainfrom
Karthik-K-N:refactor-rulestatus
Open

⚠️ Remove per node-data from rule status#131
Karthik-K-N wants to merge 1 commit intokubernetes-sigs:mainfrom
Karthik-K-N:refactor-rulestatus

Conversation

@Karthik-K-N
Copy link
Contributor

@Karthik-K-N Karthik-K-N commented Feb 19, 2026 •
edited by ajaysundark
Loading

Description

This PR updates the NRR CRD status filed to remove the per-node related data.

Related Issue

Fixes #111

Type of Change

/kind api-change

Testing

Checklist

  • make test passes
  • make lint passes

Does this PR introduce a user-facing change?

scalability: Update NodeReadinessRule Status object to remove the node related data.

Doc #(issue)

@k8s-ci-robot k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Feb 19, 2026
@netlify
Copy link

netlify bot commented Feb 19, 2026 •
edited
Loading

✅ Deploy Preview for node-readiness-controller ready!

Name Link
🔨 Latest commit a0c2b84
🔍 Latest deploy log https://app.netlify.com/projects/node-readiness-controller/deploys/69988b92c942f200083b8dd8
😎 Deploy Preview https://deploy-preview-131--node-readiness-controller.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 19, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Karthik-K-N
Once this PR has been reviewed and has the lgtm label, please assign haircommander for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 19, 2026
@Karthik-K-N Karthik-K-N changed the title Remove per node-data from rule status ⚠️ Remove per node-data from rule status Feb 19, 2026
@ajaysundark
Copy link
Contributor

ajaysundark commented Feb 24, 2026

Thanks @Karthik-K-N , I'll get to it this week.

@ajaysundark ajaysundark requested review from ajaysundark and removed request for dchen1107 and tallclair February 24, 2026 08:11
ajaysundark
ajaysundark reviewed Feb 26, 2026
View reviewed changes
internal/controller/node_controller.go
"node", node.Name, "rule", rule.Name)
// Continue with other rules even if one fails
r.recordNodeFailure(rule, node.Name, "EvaluationError", err.Error())
r.recorder.Eventf(node, corev1.EventTypeWarning, "RuleEvaluationError", "Failed to evaluate rule for node: %v", err)
Copy link
Contributor

@ajaysundark ajaysundark Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @Priyankasaggu11929 This PR introduces event recorder and some node eventing which may be related to #134

Copy link
Member

@Priyankasaggu11929 Priyankasaggu11929 Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack-ing ^ @ajaysundark

@ajaysundark
Copy link
Contributor

ajaysundark commented Feb 26, 2026

@Karthik-K-N This direction looks good to me. As we discussed, we need to plan for a scalability test before spending much of the effort in refactoring and api reshaping.

@Karthik-K-N
Copy link
Contributor Author

Karthik-K-N commented Feb 26, 2026

@Karthik-K-N This direction looks good to me. As we discussed, we need to plan for a scalability test before spending much of the effort in refactoring and api reshaping.

sure will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajaysundark ajaysundark ajaysundark left review comments

@Priyankasaggu11929 Priyankasaggu11929 Priyankasaggu11929 left review comments

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove per node-data from rule.status

4 participants

@Karthik-K-N @k8s-ci-robot @ajaysundark @Priyankasaggu11929