Skip to content

[cinder-csi-plugin] Fix incorrect RPC name in ListSnapshots error message#3122

Open
hemna wants to merge 1 commit into
kubernetes:masterfrom
hemna:fix/list-snapshots-error-message
Open

[cinder-csi-plugin] Fix incorrect RPC name in ListSnapshots error message#3122
hemna wants to merge 1 commit into
kubernetes:masterfrom
hemna:fix/list-snapshots-error-message

Conversation

@hemna
Copy link
Copy Markdown
Contributor

@hemna hemna commented Jun 5, 2026

What this PR does / why we need it:

The error message when the cloud is undefined in ListSnapshots incorrectly references [DeleteSnapshot] due to a copy-paste error. This fixes it to say [ListSnapshots], making log messages accurate for operators debugging failures.

Which issue this PR fixes(if applicable):
fixes #

Special notes for reviewers:
One-line fix, copy-paste error in an error string.

Release note:

NONE

…sage

The error message when the cloud is undefined in ListSnapshots
incorrectly references "[DeleteSnapshot]" due to a copy-paste error.
Fix it to say "[ListSnapshots]".

Signed-off-by: Walter Boring <waboring@hemna.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 5, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zetaab for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @hemna. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot requested review from kayrus and stephenfin June 5, 2026 13:56
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 5, 2026
@kayrus
Copy link
Copy Markdown
Contributor

kayrus commented Jun 5, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants