Skip to content

fix: preserve list markers on named slice types - #632

Open
Harsh-128 wants to merge 1 commit into
kubernetes:masterfrom
Harsh-128:fix/openapi-list-markers
Open

fix: preserve list markers on named slice types#632
Harsh-128 wants to merge 1 commit into
kubernetes:masterfrom
Harsh-128:fix/openapi-list-markers

Conversation

@Harsh-128

Copy link
Copy Markdown

What happened

List markers on named slice types were not being picked up when the type was used as a struct field.

For example, when a field uses a named slice type:

type NamedItemList []string

with markers such as:

// +listType=map
// +listMapKey=port

the generated OpenAPI schema did not include the corresponding list extensions.

What changed

The generator now also checks the comments on the alias type when generating member extensions.

A regression test was added to TestExtensions covering a named slice type with +listType=map and +listMapKey=port.

Testing

  • go test ./pkg/generators -run TestExtensions -count=1
  • go test ./pkg/generators/...
  • git diff --check

@linux-foundation-easycla

linux-foundation-easycla Bot commented Aug 11, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: Harsh-128 / name: Harsh-128 (1043415)

@kubernetes-prow

Copy link
Copy Markdown
Contributor

Welcome @Harsh-128!

It looks like this is your first PR to kubernetes/kube-openapi 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-openapi has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 11, 2026
@kubernetes-prow
kubernetes-prow Bot requested a review from Jefftree August 11, 2026 17:49
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Harsh-128
Once this PR has been reviewed and has the lgtm label, please assign jpbetz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow
kubernetes-prow Bot requested a review from sttts August 11, 2026 17:49
@kubernetes-prow kubernetes-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant