You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
This pull-request has been approved by: Harsh-128 Once this PR has been reviewed and has the lgtm label, please assign jpbetz for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Details
Needs approval from an approver in each of these files:
kubernetes-prowBot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
and removed
cncf-cla: no
Indicates the PR's author has not signed the CNCF CLA.
labels
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cncf-cla: yesIndicates the PR's author has signed the CNCF CLA.size/MDenotes a PR that changes 30-99 lines, ignoring generated files.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happened
List markers on named slice types were not being picked up when the type was used as a struct field.
For example, when a field uses a named slice type:
type NamedItemList []string
with markers such as:
// +listType=map
// +listMapKey=port
the generated OpenAPI schema did not include the corresponding list extensions.
What changed
The generator now also checks the comments on the alias type when generating member extensions.
A regression test was added to
TestExtensionscovering a named slice type with+listType=mapand+listMapKey=port.Testing
go test ./pkg/generators -run TestExtensions -count=1go test ./pkg/generators/...git diff --check