Add tests for obs/archive file#4318
Open
TatianaSelezneva wants to merge 1 commit intokubernetes:masterfrom
Open
Add tests for obs/archive file#4318TatianaSelezneva wants to merge 1 commit intokubernetes:masterfrom
TatianaSelezneva wants to merge 1 commit intokubernetes:masterfrom
Conversation
k8s-ci-robot
added
release-note-none
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: TatianaSelezneva The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
needs-priority
area/release-eng
k8s-ci-robot
added
size/L
TatianaSelezneva
force-pushed
the
master
branch
from
5532536 to
1c652af
Compare
TatianaSelezneva
force-pushed
the
master
branch
from
1c652af to
44c0863
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
We are missing unit tests for krel obs and this PR attempts to improve coverage
Relevant card from the project board: #3168
Which issue(s) this PR fixes:
It improves unit test coverage for the krel obs/archive
Special notes for your reviewer:
PR includes tests for specs/template.go. It is incremental improvement for obs package tests. We need to add tests to 'archive.go' to complete the suite.
Does this PR introduce a user-facing change?