fix: pin osc to 1.23.0 in k8s-cloud-builder#4331
Closed
saschagrunert wants to merge 1 commit intokubernetes:masterfrom
Closed
fix: pin osc to 1.23.0 in k8s-cloud-builder#4331saschagrunert wants to merge 1 commit intokubernetes:masterfrom
saschagrunert wants to merge 1 commit intokubernetes:masterfrom
Conversation
247d3a0 to
ba60b2e
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
osc 1.25.0 changed the config file lookup order to prefer XDG paths over ~/.oscrc, causing OBS stage/release Cloud Build jobs to fail with HTTP 401 on osc whois. Pin to 1.23.0 which is the last known working version and track it in dependencies.yaml. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
ba60b2e to
b190ee5
Compare
Member
Author
|
/hold |
Member
Author
|
Transient failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/kind bug
What this PR does / why we need it:
Pin osc to 1.23.0 in the k8s-cloud-builder Dockerfile. osc 1.25.0 changed the config file lookup order to prefer XDG paths over
~/.oscrc, causing OBS stage/release Cloud Build jobs to fail withHTTP Error 401: Unauthorizedonosc whois.The proper fix is in kubernetes-sigs/release-sdk#531, this is the immediate workaround.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
osc is currently installed via
pip3 install oscwithout a pinned version. Every k8s-cloud-builder image rebuild picks up the latest version from PyPI. The February patches used osc 1.23.0 (working), the March rebuilds pulled 1.25.0 (broken).Does this PR introduce a user-facing change?