Skip to content

Improve krel announce send output#4333

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
saschagrunert:fix/announce-send-ux
Mar 20, 2026
Merged

Improve krel announce send output#4333
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
saschagrunert:fix/announce-send-ux

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Mar 19, 2026

What type of PR is this?

/kind bug

What this PR does / why we need it:

  • Reduce helpers.Ask retries from 10 to 1 to avoid the confusing (1/10) counter on a yes/no prompt
  • Log mailing list URLs after a successful send so the release manager can verify the announcement

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

krel announce send now logs mailing list URLs after sending and no longer shows a confusing retry counter on the confirmation prompt.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject labels Mar 19, 2026
@k8s-ci-robot k8s-ci-robot requested a review from jimangel March 19, 2026 09:00
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from jrsapi March 19, 2026 09:00
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 19, 2026
@saschagrunert saschagrunert changed the title fix: improve krel announce send UX fix: improve krel announce send output Mar 19, 2026
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 19, 2026
@saschagrunert saschagrunert changed the title fix: improve krel announce send output Improve krel announce send output Mar 19, 2026
Reduce Ask retries from 10 to 1 to avoid the confusing "(1/10)"
counter on a simple yes/no prompt. Log mailing list URLs after
a successful send so the release manager can verify the announcement.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert
Copy link
Member Author

@kubernetes/release-engineering PTAL

@ameukam
Copy link
Member

ameukam commented Mar 20, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2026
@k8s-ci-robot k8s-ci-robot merged commit da14d7e into kubernetes:master Mar 20, 2026
11 checks passed
@saschagrunert saschagrunert deleted the fix/announce-send-ux branch March 20, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants