Parallelize manifest list create, push, and sign operations#4335
Open
saschagrunert wants to merge 1 commit intokubernetes:masterfrom
Open
Parallelize manifest list create, push, and sign operations#4335saschagrunert wants to merge 1 commit intokubernetes:masterfrom
saschagrunert wants to merge 1 commit intokubernetes:masterfrom
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/release-eng
k8s-ci-robot
added
size/L
Process manifest lists in parallel using errgroup with bounded concurrency instead of sequentially. Each image's manifest create, push (with retry), and sign operations are independent. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
force-pushed
the
perf/parallel-manifest-push
branch
from
74e7417 to
c753507
Compare
saschagrunert
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Member
Author
|
@kubernetes/release-engineering PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Parallelizes Phase 3 of container image publishing (manifest list create, push, sign) using errgroup with bounded concurrency. Currently 6 images are processed sequentially at ~1 min each. This brings it from ~5 min to ~1 min.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Part of a series of krel stage performance improvements.
Does this PR introduce a user-facing change?