Add step IDs to stage Cloud Build config#4336
Closed
saschagrunert wants to merge 1 commit intokubernetes:masterfrom
Closed
Add step IDs to stage Cloud Build config#4336saschagrunert wants to merge 1 commit intokubernetes:masterfrom
saschagrunert wants to merge 1 commit intokubernetes:masterfrom
Conversation
k8s-ci-robot
added
release-note-none
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
k8s-ci-robot
added
the
size/XS
saschagrunert
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Add explicit step IDs to all Cloud Build steps for better log readability and debuggability. The OBS stage step uses waitFor to depend on the stage step, since it downloads artifacts from the GCS path that krel stage uploads to. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
changed the title
saschagrunert
force-pushed
the
perf/parallel-obs-stage
branch
from
2c8330b to
4f6fb3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Adds explicit
idfields to all Cloud Build steps ingcb/stage/cloudbuild.yamlfor better log readability and debuggability.Which issue(s) this PR fixes:
None
Special notes for your reviewer:
The
waitFor: ['stage']on obs-stage is functionally equivalent to the default sequential behavior but makes the dependency on staged GCS artifacts explicit.Does this PR introduce a user-facing change?