Revert blobless clone for k/k checkouts during stage#4339
Closed
saschagrunert wants to merge 1 commit intokubernetes:masterfrom
Closed
Revert blobless clone for k/k checkouts during stage#4339saschagrunert wants to merge 1 commit intokubernetes:masterfrom
saschagrunert wants to merge 1 commit intokubernetes:masterfrom
Conversation
This reverts commit 3d02b4a.
k8s-ci-robot
added
kind/bug
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/release-eng
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Reverts commit 3d02b4a ("Use blobless clone for fresh k/k checkouts during stage"). The blobless clone (
--filter=blob:none) causesgit commit --allow-emptyto fail during the tagging step with "invalid object" errors. The GCB cloud builder image uses git 2.30.2, which has incomplete support for partial clone tree validation. This broke mock stage runs for both release-1.35 and release-1.34.Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Confirmed that reverting to a full clone fixes the issue. The blobless clone optimization can be revisited once the cloud builder image ships a newer git version.
Does this PR introduce a user-facing change?