Clarify what maxSkew does with whenUnsatisfiable: ScheduleAnyway#56532
Open
emmayusufu wants to merge 1 commit into
Open
Clarify what maxSkew does with whenUnsatisfiable: ScheduleAnyway#56532emmayusufu wants to merge 1 commit into
emmayusufu wants to merge 1 commit into
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
language/en
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The maxSkew section says its semantics differ by whenUnsatisfiable, but only explains the DoNotSchedule case. This adds what happens with ScheduleAnyway: maxSkew is not enforced there, it only tunes how strongly the scheduler prefers lower skew when scoring nodes (see scoreForCount in pkg/scheduler/framework/plugins/podtopologyspread/scoring.go, where the maxSkew-1 term waters down score differences between domains).
Fixes #56452