Conversation
| # Details ServiceExport | ||
| ################################################################################## | ||
| apiVersion: networking.kubeslice.io/v1beta1 | ||
| apiVersion: mesh.avesha.io/v1beta1 |
There was a problem hiding this comment.
Good observation. I copied this config file from the latest version of the internal doc and didn't notice this change.
| inline = [ | ||
| "cd /tmp/examples", | ||
| "git checkout ec2", | ||
| "git checkout bookinfo", |
There was a problem hiding this comment.
Why are we doing a git checkout of bookinfo (or ec2)? Presumably once this merges to master we'd use the code on the master branch (not on the bookinfo... or ec2... branch)? Should this just use the code from whatever branch it is on?
There was a problem hiding this comment.
it's because I need to test the changes before they go to master. If I would just checkout master branch I wouldn't be able to see the modifications to bookinfo. This is the same problem I had with devops-510: I needed to checkout that branch to really test the changes.
There was a problem hiding this comment.
I see... because you're using ec2 to test the bookinfo changes and its doing its own clone you need it to grab this branch. Ok, please be sure to do another commit after this to remove the checkout of the bookinfo branch.
eric978
left a comment
eric978
left a comment
There was a problem hiding this comment.
After the fix from JD and the clarification on the ec2 branch, it LGTM.
|
Actually, I don't think kind.sh should be added a namespace for bookinfo (a kind.sh user will end up with a bookinfo namespace that they don't use). IMO all the bookinfo stuff should be in the bookinfo app/dir. This can be an example of adding a namespace to an existing slice (or adding a new slice... either way). |
|
@eric978 That's a good point. What about the slice.yaml file? Can I reapply that same same file and just add the info about the new namespace? Should I create a new slice just for bookinfo? |
|
IMO, it's probably cleanest to just make a new slice for bookinfo
…On Tue, Jun 21, 2022 at 12:20 PM Juan Veras ***@***.***> wrote:
@eric978 <https://github.com/eric978> That's a good point. What about the
slice.yaml file? Can I reapply that same same file and just add the info
about the new namespace? Should I create a new slice just for bookinfo?
—
Reply to this email directly, view it on GitHub
<#17 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AX2CF2WC7KQVS3PTPMV5BB3VQHTV3ANCNFSM5ZMKBBNA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
3 participants
Modifies bookinfo configuration yaml files to support namespace onboarding