Conversation
| kubectl get pods -n calico-system | ||
| echo "Wait for Calico to be Running" | ||
| namespace=calico-system | ||
| sleep=900 |
There was a problem hiding this comment.
Sleep 900 seems excessive? If it's not going to work, could we fail faster? Fwiw, in my testing it tool 32sec for calico to be ready... so 60 or 90 might be fine?
There was a problem hiding this comment.
It's taking more than 600secs in Amazon EC2, macOS Monterey 12.4 Instance, that why updated with Sleep 900.
| done | ||
| done | ||
| done | ||
| } |
There was a problem hiding this comment.
I'm tempted to say wait_for_... should be generalized to wait for -condition- on -command- and be put into the util dir so anything can use it.
But we've got big changes in this file coming when Deepankar's slicectl is ready for use... so fine to hold off until then.
| @@ -0,0 +1,425 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
Why did we have to make a completely separate copy for mac? Was there no way to conditionalize the mac parts inside the script? It'll be a hassle maintaining two separate scripts and keeping them functionally in sync... would be better if there was just one.
There was a problem hiding this comment.
Due to the high number of modifications in the script, We decided to make a separate copy for mac. There is a way to conditionalize the mac parts inside the script.
There was a problem hiding this comment.
First, it doesn't look like an especially high number of mods. I see 14 total changes. Running macos-kind.sh on Ubuntu generally works (except for the check for colima... which I don't see used by the script isn't obviously used to me?). For each change:
- getopts change works on linux
- if check after getops is ok on linux
- assuming the colima check is needed, set the OS to "mac" and make it conditional
- The various "sleeps" should ideally be replaced by "wait_for_..." but if you want to leave them just pick a number that is good for both
- Looks like the sed issue is just about:
sed -i '' ...
...vs...
sed ...
So why not do something like:
(at the top) BSDSED=" "
(inside the macos plaform check make it two signle quotes inside the double quotes) BSDSED="''"
Then make each sed line be:
sed -i $BSDSED ...
Not sure what the "14i" sed for 14i is for? Can we fix that to work for both?
|
looks like colima https://github.com/abiosoft/colima can create kubernetes cluster itself. Why do we need kind clusters then? |
|
Wow. Ok. Not sure I'd wait that long myself... but if that's what it
is then that's fine.
…On Tue, Jun 21, 2022 at 4:44 PM Kranthi Kumar ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In kind/kind.sh
<#18 (comment)>:
> +kubectx $PREFIX$CONTROLLER
+kubectx
+
+echo Install the Tigera Calico operator...
+kubectl create -f https://projectcalico.docs.tigera.io/manifests/tigera-operator.yaml
+
+echo Install the custom resource definitions manifest...
+kubectl create -f https://projectcalico.docs.tigera.io/manifests/custom-resources.yaml
+sleep 120
+
+echo "Check for Calico namespaces, pods"
+kubectl get ns
+kubectl get pods -n calico-system
+echo "Wait for Calico to be Running"
+namespace=calico-system
+sleep=900
It's taking more than 600secs in Amazon EC2, macOS Monterey 12.4
Instances, that why updated with Sleep 900.
—
Reply to this email directly, view it on GitHub
<#18 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AX2CF2QJENJ4VKOUEWHXMY3VQISUJANCNFSM5ZNARS7Q>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
@KRANTHI0918 What's going on with this PR? Were you going to make the changes? |
3 participants
Updated the scripts to cover kubeslice kind cluster setup on mac os versions along Calico Installation.