test(): Added unit tests for pkg/manifest/ingress.go file#440
Open
Alokzh wants to merge 2 commits intokubeslice:masterfrom
Open
test(): Added unit tests for pkg/manifest/ingress.go file#440Alokzh wants to merge 2 commits intokubeslice:masterfrom
Alokzh wants to merge 2 commits intokubeslice:masterfrom
Conversation
Signed-off-by: Alokzh <zhalok24@gmail.com>
Alokzh
requested review from
Rahul-D78,
bharath-avesha,
gourishkb,
narmidm and
richiesebastian
as code owners
gourishkb
reviewed
Aug 12, 2025
gourishkb
approved these changes
Aug 12, 2025
Contributor
gourishkb
left a comment
gourishkb
left a comment
There was a problem hiding this comment.
Minor change required in one test case. Looks good to me otherwise
Signed-off-by: Alokzh <zhalok24@gmail.com>
gourishkb
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces comprehensive unit tests for the ingress manifest functionality in the
pkg/manifestpackageHow Has This Been Tested?
The new functionality has been validated through local unit testing:
Tests cover:
Checklist:
go fmtDoes this PR introduce a breaking change?