fix(): Add Istio mTLS exclusion for application pods while communicating with NSM manager on port 5000#445
Open
greninja517 wants to merge 1 commit intokubeslice:masterfrom
Open
fix(): Add Istio mTLS exclusion for application pods while communicating with NSM manager on port 5000#445greninja517 wants to merge 1 commit intokubeslice:masterfrom
greninja517 wants to merge 1 commit intokubeslice:masterfrom
Conversation
…ating with NSM manager in Strict mode Signed-off-by: anjal <anjalpoudel517+github@gmail.com>
greninja517
requested review from
Rahul-D78,
bharath-avesha,
gourishkb,
narmidm and
richiesebastian
as code owners
Contributor
|
Hey @greninja517 thanks for the PR, can you please share how you have tested these changes ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue #331 where application pods in slices crash when Istio peer authentication is set to
STRICTmode. PR modifies theapplicationPodby introducing an annotation that bypasses IstiomTLSon port 5000 while communicating with NSM manager during the pod registration in the slice.This allows NSM communication to bypass mTLS enforcement while preserving security for all other traffic.
Fixes #331
How Has This Been Tested?
Checklist:
go fmtDoes this PR introduce a breaking change?