Avoid hotloop over empty clusterrole rules#28
Avoid hotloop over empty clusterrole rules#28akalenyu wants to merge 1 commit intokubevirt:masterfrom
Conversation
For an empty list, we get in a hotloop over it being persisted with nil
```
2026-01-14T04:29:20Z INFO DIFF {"controller": "migcontroller-controller", "object": {"name":"migcontroller-kubevirt-hyperconverged","namespace":"openshift-cnv"}, "namespace": "openshift-cnv", "name": "migcontroller-kubevirt-hyperconverged", "reconcileID": "d5cabc29-c944-4271-8b88-b5284c55c266", "obj": {"apiVersion": "rbac.authorization.k8s.io/v1", "kind": "ClusterRole", "name": "migrations.kubevirt.io:admin"}, "patch": "[{\"op\":\"add\",\"path\":\"/rules\",\"value\":[]}]"}
```
Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
4cf993b to
dc4253f
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akalenyu, maiqueb The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
|
There has been no activity on this PR for 59 days and it has been stale for 14 days. What you can do:
/lifecycle rotten |
What this PR does / why we need it:
For an empty list, we get in a hotloop over it being persisted with nil
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: