Refactor Get/List VirtualMachine methods to reflect VMI return types#178
Refactor Get/List VirtualMachine methods to reflect VMI return types#178kellydx wants to merge 1 commit intokubevirt:mainfrom
Conversation
The original names were misleading because the functions return VirtualMachineInstance types. The changes in mocked_client.go are auto-generated. Signed-off-by: Kelly Duong <kellyduong@google.com>
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @kellydx. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
There has been no activity on this PR for 45 days. What you can do:
/lifecycle stale |
|
/remove-lifecycle stale |
Refactor Get/List VirtualMachine methods to reflect VMI return types
What this PR does / why we need it:
The original function names were misleading because the functions return VirtualMachineInstance types.
The changes in mocked_client.go is auto generated.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: