Added display mode selection feature and implemented compact mode #34
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -50,7 +50,7 @@ | |||||
| --btn-primary-hover: #1f2328; | ||||||
| --btn-primary-active: #1c2128; | ||||||
| --btn-primary-shadow: 0 1px 0 rgba(31, 35, 40, 0.1), | ||||||
| inset 0 1px 0 rgba(255, 255, 255, 0.03); | ||||||
|
|
||||||
| --btn-danger-bg: #cf222e; | ||||||
| --btn-danger-hover: #a40e26; | ||||||
|
|
@@ -63,7 +63,7 @@ | |||||
|
|
||||||
| /* Typography */ | ||||||
| --font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Noto Sans", | ||||||
| Helvetica, Arial, sans-serif; | ||||||
| --font-size-xs: 12px; | ||||||
| --font-size-sm: 13px; | ||||||
| --font-size-base: 14px; | ||||||
|
|
@@ -217,8 +217,7 @@ body { | |||||
| .popup__btn--primary:hover:not(:disabled) { | ||||||
| background-color: var(--btn-github-hover); | ||||||
| border-color: rgba(31, 35, 40, 0.25); | ||||||
| box-shadow: 0 1px 0 rgba(31, 35, 40, 0.1), 0 0 0 3px rgba(36, 41, 47, 0.1); | ||||||
| } | ||||||
|
|
||||||
| .popup__btn--primary:active:not(:disabled) { | ||||||
|
|
@@ -309,7 +308,11 @@ body { | |||||
| width: 40px; | ||||||
| height: 40px; | ||||||
| border-radius: var(--radius-full); | ||||||
| background: linear-gradient( | ||||||
| 135deg, | ||||||
| var(--color-success-emphasis) 0%, | ||||||
| var(--color-accent-emphasis) 100% | ||||||
| ); | ||||||
| display: flex; | ||||||
| align-items: center; | ||||||
| justify-content: center; | ||||||
|
|
@@ -467,7 +470,8 @@ body { | |||||
| } | ||||||
|
|
||||||
| @keyframes successPulse { | ||||||
| 0%, | ||||||
| 100% { | ||||||
| transform: scale(1); | ||||||
| } | ||||||
| 50% { | ||||||
|
|
@@ -479,6 +483,49 @@ body { | |||||
| animation: successPulse 0.5s ease-out; | ||||||
| } | ||||||
|
|
||||||
| /* ============================================ | ||||||
| Settings | ||||||
| ============================================ */ | ||||||
|
|
||||||
| .popup__setting { | ||||||
| margin-bottom: var(--space-4); | ||||||
| padding: var(--space-4); | ||||||
| background-color: var(--color-canvas-subtle); | ||||||
| border: 1px solid var(--color-border-muted); | ||||||
| border-radius: var(--radius-md); | ||||||
| } | ||||||
|
|
||||||
| .popup__setting-label { | ||||||
| display: block; | ||||||
| font-size: var(--font-size-sm); | ||||||
| font-weight: var(--font-weight-medium); | ||||||
| color: var(--color-fg-default); | ||||||
| margin-bottom: var(--space-2); | ||||||
| } | ||||||
|
|
||||||
| .popup__setting-select { | ||||||
| width: 100%; | ||||||
| padding: var(--space-2) var(--space-3); | ||||||
| font-family: inherit; | ||||||
| font-size: var(--font-size-sm); | ||||||
| color: var(--color-fg-default); | ||||||
| background-color: var(--color-canvas-default); | ||||||
| border: 1px solid var(--color-border-default); | ||||||
| border-radius: var(--radius-md); | ||||||
| cursor: pointer; | ||||||
| transition: all var(--transition-fast); | ||||||
|
There was a problem hiding this comment. Using
Suggested change
Style Guide ReferencesFootnotes
|
||||||
| } | ||||||
|
|
||||||
| .popup__setting-select:hover { | ||||||
| border-color: var(--color-accent-emphasis); | ||||||
| } | ||||||
|
|
||||||
| .popup__setting-select:focus { | ||||||
| outline: none; | ||||||
| border-color: var(--color-accent-emphasis); | ||||||
| box-shadow: 0 0 0 3px var(--color-accent-bg); | ||||||
| } | ||||||
|
|
||||||
| /* ============================================ | ||||||
| Utilities | ||||||
| ============================================ */ | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The style rules for
[data-color-mode="dark"]from line 119 to 138 are duplicates of the rules within the@media (prefers-color-scheme: dark)block (lines 95-116). This introduces code duplication, which goes against the repository's style guide (L15: 'when you see signs of reuse, modularize it to avoid code duplication').For better maintainability, it's recommended to avoid repeating these blocks of CSS. While handling both system preference and manual theme selection in pure CSS can be tricky, this duplication can make future updates error-prone and harder to maintain.
Style Guide References