Merged
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Owner
Author
|
Looks like this is successfully using code coverage when running tests and uploading it so I think it's ready for review! |
ciortiz
approved these changes
Dec 6, 2024
Collaborator
ciortiz
left a comment
ciortiz
left a comment
There was a problem hiding this comment.
It seems to me that this pull request does the following:
- Each Python version will have its own nox session, and we only care to run code coverage for the Python 3.11 version (which is fine if we care to only run code coverage once).
- Code coverage will report back regardless of the success of and without waiting for (presumably)
ci.yml. - Nox sessions' procedures with and without code coverage are defined via changes in
noxfile.py.
Looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request will close #11 and will make the github actions autocheck the testing coverage.