feat(utils.js): replace for-in with Object.keys in noteGlobalProps()#58
Open
attax1994 wants to merge 1 commit intokuitos:masterfrom
attax1994:feat/replace-for-in-with-object-keys
Open
feat(utils.js): replace for-in with Object.keys in noteGlobalProps()#58attax1994 wants to merge 1 commit intokuitos:masterfrom attax1994:feat/replace-for-in-with-object-keys
attax1994 wants to merge 1 commit intokuitos:masterfrom
attax1994:feat/replace-for-in-with-object-keys
Conversation
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
=======================================
Coverage 52.91% 52.91%
=======================================
Files 3 3
Lines 257 257
Branches 82 82
=======================================
Hits 136 136
Misses 90 90
Partials 31 31
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
实现方案
用例:
3种实现方案分别对 window 进行1000遍历,并执行 firstGlobalProp、secondGlobalProp、lastGlobalProp 的赋值操作。
结果
分析:
遗留问题: