Skip to content

Eager dummy #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kumare3 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Eager dummy #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d494c0b
fix eager error
kumare3 Mar 11, 2025
a753655
wip
kumare3 Mar 13, 2025
8f34312
working
kumare3 Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,4 @@ coverage.xml

# Version file is auto-generated by setuptools_scm
flytekit/_version.py
testing
samplecode
10 changes: 5 additions & 5 deletions flytekit/core/context_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
if typing.TYPE_CHECKING:
from flytekit.clients import friendly as friendly_client # noqa
from flytekit.clients.friendly import SynchronousFlyteClient
from flytekit.core.worker_queue import Controller
from flytekit.core.eager_controller import EagerController
from flytekit.deck.deck import Deck

# TODO: resolve circular import from flytekit.core.python_auto_container import TaskResolverMixin
Expand Down Expand Up @@ -699,7 +699,7 @@ class FlyteContext(object):
in_a_condition: bool = False
origin_stackframe: Optional[traceback.FrameSummary] = None
output_metadata_tracker: Optional[OutputMetadataTracker] = None
worker_queue: Optional[Controller] = None
worker_queue: Optional[EagerController] = None

@property
def user_space_params(self) -> Optional[ExecutionParameters]:
Expand Down Expand Up @@ -751,7 +751,7 @@ def with_serialization_settings(self, ss: SerializationSettings) -> Builder:
def with_output_metadata_tracker(self, t: OutputMetadataTracker) -> Builder:
return self.new_builder().with_output_metadata_tracker(t)

def with_worker_queue(self, wq: Controller) -> Builder:
def with_worker_queue(self, wq: EagerController) -> Builder:
return self.new_builder().with_worker_queue(wq)

def with_client(self, c: SynchronousFlyteClient) -> Builder:
Expand Down Expand Up @@ -820,7 +820,7 @@ class Builder(object):
serialization_settings: Optional[SerializationSettings] = None
in_a_condition: bool = False
output_metadata_tracker: Optional[OutputMetadataTracker] = None
worker_queue: Optional[Controller] = None
worker_queue: Optional[EagerController] = None

def build(self) -> FlyteContext:
return FlyteContext(
Expand Down Expand Up @@ -881,7 +881,7 @@ def with_output_metadata_tracker(self, t: OutputMetadataTracker) -> FlyteContext
self.output_metadata_tracker = t
return self

def with_worker_queue(self, wq: Controller) -> FlyteContext.Builder:
def with_worker_queue(self, wq: EagerController) -> FlyteContext.Builder:
self.worker_queue = wq
return self

Expand Down
Loading