fix: make Lavish rich reviews safe by default#650
Open
julesLubrano wants to merge 8 commits into
Open
Conversation
Centralize the rich-review and decision-input contract in decision-hold-lifecycle. Keep approvals in primary chat unless durable return and idempotent acknowledgement are verified. No executable test is added because the change is instruction-only and phrase assertions would be brittle.
…ompletion coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
No-mistakes run 01KXP2CBG9THF5T5MMBBC9HAXQ completed intent, rebase, review, test, document, and lint against the rebased branch, with push, PR, and CI intentionally skipped because the stored delivery target ignored the authorized fork.
Focused fm-brief, decision-hold-lifecycle, and captain-translation tests passed. The full repository suite completed with two pre-existing environment gates approved: ShellCheck 0.11.0 is unavailable locally, and one restricted-PATH test cannot see the installed jq binary. Repository lint likewise could not run without the pinned ShellCheck version.
CI status is not claimed here and must be verified on this PR.