Skip to content

Make sure we fail on yup modules circular deps#111

Merged
kunitoki merged 1 commit into
mainfrom
dev/circular_deps
Jun 3, 2026
Merged

Make sure we fail on yup modules circular deps#111
kunitoki merged 1 commit into
mainfrom
dev/circular_deps

Conversation

@kunitoki
Copy link
Copy Markdown
Owner

@kunitoki kunitoki commented Jun 3, 2026

This pull request introduces logic to detect and prevent circular dependencies between YUP modules at CMake configuration time. The main changes add helper functions to normalize dependency targets and recursively check for cycles, and integrate these checks into both plugin and standalone application build functions.

Dependency cycle detection:

  • Added _yup_module_normalize_dependency_target, _yup_module_check_dependency_cycle, and _yup_module_check_circular_dependencies helper functions to cmake/yup_modules.cmake. These functions normalize dependency names, recursively check for circular dependencies, and emit a fatal error with a clear message if a cycle is detected.

Integration with build functions:

  • Updated yup_audio_plugin in cmake/yup_audio_plugin.cmake to check for circular dependencies among specified modules (including yup_audio_plugin_client and optionally yup_audio_devices) before proceeding with plugin build steps.
  • Updated yup_standalone_app in cmake/yup_standalone.cmake to check for circular dependencies among specified modules before proceeding with application build steps.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.50%. Comparing base (b3f73ef) to head (d95f53c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
+ Coverage   78.46%   78.50%   +0.03%     
==========================================
  Files         605      605              
  Lines       60548    60548              
==========================================
+ Hits        47508    47532      +24     
+ Misses      13040    13016      -24     

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3f73ef...d95f53c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kunitoki kunitoki merged commit b0e166d into main Jun 3, 2026
40 checks passed
@kunitoki kunitoki deleted the dev/circular_deps branch June 3, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant