Make sure we fail on yup modules circular deps#111
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
==========================================
+ Coverage 78.46% 78.50% +0.03%
==========================================
Files 605 605
Lines 60548 60548
==========================================
+ Hits 47508 47532 +24
+ Misses 13040 13016 -24 see 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces logic to detect and prevent circular dependencies between YUP modules at CMake configuration time. The main changes add helper functions to normalize dependency targets and recursively check for cycles, and integrate these checks into both plugin and standalone application build functions.
Dependency cycle detection:
_yup_module_normalize_dependency_target,_yup_module_check_dependency_cycle, and_yup_module_check_circular_dependencieshelper functions tocmake/yup_modules.cmake. These functions normalize dependency names, recursively check for circular dependencies, and emit a fatal error with a clear message if a cycle is detected.Integration with build functions:
yup_audio_pluginincmake/yup_audio_plugin.cmaketo check for circular dependencies among specified modules (includingyup_audio_plugin_clientand optionallyyup_audio_devices) before proceeding with plugin build steps.yup_standalone_appincmake/yup_standalone.cmaketo check for circular dependencies among specified modules before proceeding with application build steps.