Fix combobox popup menu#114
Open
kunitoki wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
+ Coverage 78.50% 78.61% +0.11%
==========================================
Files 605 605
Lines 60548 60566 +18
==========================================
+ Hits 47531 47614 +83
+ Misses 13017 12952 -65
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the
ComboBoxwidget's popup menu interaction logic and enhances the text layout behavior in theLabelwidget. The main focus is on preventing the popup menu from immediately reopening after dismissal due to a mouse click, ensuring a smoother user experience. Additionally, the pull request includes a test to verify the new popup behavior and refines how text is rendered in labels to better fit available space.ComboBox popup interaction improvements
ComboBoxto prevent the popup menu from reopening immediately after it is dismissed by a mouse click, using new state flags (ignoreMouseDownAfterPopupDismissal,dismissingPopupFromMouseDown) and handling withinmouseDownandshowPopupmethods. [1] [2] [3]PopupDismissalClickDoesNotReopenPopupto verify that a click used to dismiss the popup does not immediately reopen it, ensuring correct behavior.Label text layout improvements
Label::prepareTextmethod to use the provided font or fallback to the default, and to dynamically adjust the font size so that text fits within the available width, preventing overflow and improving appearance. Also changed text overflow handling from ellipsis to visible.