Skip to content

Enable twofish as an optional dependency#69

Open
blim747 wants to merge 1 commit intokurtbrose:masterfrom
blim747:master
Open

Enable twofish as an optional dependency#69
blim747 wants to merge 1 commit intokurtbrose:masterfrom
blim747:master

Conversation

@blim747
Copy link
Copy Markdown

@blim747 blim747 commented Mar 15, 2021

Problem:

As of now pyjks requires the install of twofish, even though according to the README twofish is only required to read UBER keystores. twofish is a package that has no commits since 2013 and is not compatible with Python 3.3+. Installing twofish should be optional.

Solution:

Enable twofish to be installed as an extras_require.

Testing:

I was able to build with Python 2 and Python 3 without issues, with and without twofish. tox tests pass for all Python versions there are tests for.

Notes:

  • See Move off requirements.txt and enable twofish as an optional install #68 for the previous draft version of this PR with a polluted commit history. The previous change included various changes to setup.cfg and requirements.txt that are not required to enable twofish to be installed optionally.
  • Question: Can we increment the version number as part of this change?

@Warkdev
Copy link
Copy Markdown

Warkdev commented Jan 25, 2024

Any chance to see this merged and released ? :)

@mattviasat
Copy link
Copy Markdown

This would be very helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants