Enable twofish as an optional dependency#69
Open
blim747 wants to merge 1 commit intokurtbrose:masterfrom
Open
Conversation
|
Any chance to see this merged and released ? :) |
|
This would be very helpful! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
As of now
pyjksrequires the install oftwofish, even though according to the READMEtwofishis only required to read UBER keystores.twofishis a package that has no commits since 2013 and is not compatible with Python 3.3+. Installingtwofishshould be optional.Solution:
Enable
twofishto be installed as anextras_require.Testing:
I was able to build with Python 2 and Python 3 without issues, with and without
twofish.toxtests pass for all Python versions there are tests for.Notes:
setup.cfgandrequirements.txtthat are not required to enabletwofishto be installed optionally.