Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, kwatch (Kuwata-san).
This module's unit test was failed for Ruby 2.3.
ruby 2.3.0p0 (2015-12-25 revision 53290) [x86_64-linux]
About Ruby 2.2. I could succeed the test by using below pull-request
#5
So, I merged voxik's modification (support for Ruby 2.0, 2,1, 2,2) to my branch.
And I would like to do pull-request including his past modification this time.
Thank you!!
IN JAPANESE.
くわたさん
日本人の方のようですので、
日本語で捕捉させて戴きます。有賀と申します。
しばらく、このモジュールの更新がないようですが、
今、Fedora Projectで、このモジュールのRPMパッケージのメンテナンスをしておりまして、
その関係で、テストを最新のRubyで通す必要がありまして、対応しております。
できましたら、
この修正を取り込んで頂き、
将来のリリースバージョンに含めて頂けますと大変助かります。
ご質問等、ありましたら、お気軽にご連絡ください。(日本語でも!)
ありがとうございます。
有賀